Add support for setting the IME purpose - #2650
Merged
Merged
Conversation
lukaslihotzki
force-pushed
the
ime-purpose
branch
from
January 25, 2023 12:11
43573f1 to
b0fc594
Compare
lukaslihotzki
requested review from
jackpot51,
madsmtm and
msiglreith
as code owners
January 25, 2023 12:11
lukaslihotzki
force-pushed
the
ime-purpose
branch
3 times, most recently
from
January 25, 2023 12:43
a2e5268 to
497ed37
Compare
kchibisov
requested changes
Jan 27, 2023
kchibisov
left a comment
kchibisov
left a comment
Member
There was a problem hiding this comment.
The API looks fine, though we might want to change IME stuff to do a single apply with some ImeStateUpdate, so we can utilize the atomicness of some of the underlying APIs.
lukaslihotzki
force-pushed
the
ime-purpose
branch
from
January 27, 2023 04:41
497ed37 to
631a5e5
Compare
lukaslihotzki
requested review from
kchibisov
and removed request for
madsmtm and
msiglreith
January 27, 2023 04:44
lukaslihotzki
force-pushed
the
ime-purpose
branch
2 times, most recently
from
January 27, 2023 05:01
13641c8 to
71f16a6
Compare
kchibisov
requested changes
Jan 27, 2023
lukaslihotzki
force-pushed
the
ime-purpose
branch
from
January 27, 2023 05:39
71f16a6 to
55065e4
Compare
kchibisov
requested changes
Jan 27, 2023
lukaslihotzki
force-pushed
the
ime-purpose
branch
from
January 27, 2023 14:26
55065e4 to
a3437b6
Compare
This adds a way to set the purpose for the IME input, implemented only on Wayland for now.
kchibisov
force-pushed
the
ime-purpose
branch
from
January 29, 2023 15:28
a3437b6 to
9404ffe
Compare
kchibisov
approved these changes
Jan 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wayland and macOS support IME purposes. I have implemented it for Wayland only, because I don't have access to macOS. XIM and Windows IMM do not seem to support it. (Although #2614 removes XIM and the successor may support IME purposes.)
This PR adds the purpose
Password(directly supported by both Wayland and macOS) andTerminal(needed for alacritty/alacritty#6644). I don't know if it makes sense to support more purposes (for example, all that Wayland supports). TheImePurposeenum is non exhaustive, so new purposes can be added without breaking change.CHANGELOG.mdif knowledge of this change could be valuable to usersimeexample, although theimeexample does not work at all on Wayland because no window shows up)