pxe: use PxeBaseCodeBootType newtype in PxeBaseCodeSrvlist - #2055
Open
SlieNce810 wants to merge 1 commit into
Open
pxe: use PxeBaseCodeBootType newtype in PxeBaseCodeSrvlist#2055SlieNce810 wants to merge 1 commit into
SlieNce810 wants to merge 1 commit into
Conversation
Replace the bare u16 server_type with the existing PxeBaseCodeBootType newtype enum, as the field semantically holds an EFI_PXE_BASE_CODE_BOOT_TYPE value. This removes the TODO left by upstream commit a2bcaf6, and records the breaking change in both changelogs. AI-assisted contribution: implemented and validated with AI coding assistance, as required by CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the bare u16
server_typewith the existingPxeBaseCodeBootTypenewtype enum, as the field semantically holds an
EFI_PXE_BASE_CODE_BOOT_TYPEvalue. This removes the TODO left by upstream commit a2bcaf6, and records the
breaking change in both changelogs.
Closes #2047
Validation
cargo check -p uefi-raw -p uefipasses locally on host.ueficrate fail to compile on my local toolchain evenwithout this change (pre-existing errors in unrelated modules, e.g. TCG),
so I could not run them locally.
Checklist
AI disclosure
This contribution was implemented and validated with AI coding assistance,
as required by CONTRIBUTING.md. I reviewed and understood every change.
About me
I'm a graduate student at Hangzhou Dianzi University, currently learning
Rust and OS internals through rCore-Tutorial. I host my code on CNB
(cnb.cool), and I keep my exercises and notes from the tutorial in a
public repo: https://cnb.cool/u/cnb.bs8OWBnfgJA
First contribution to this project — happy to adjust anything per review.