Fetch the first 100 reviews instead of just the default 30 - #2489
Merged
Conversation
Member
|
Hmm, if it includes also review threads, then we should definitely loop. But as a hotfix, seems fine. Thanks for looking into it! |
Kobzol
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported at #t-clippy > rustbot not moving an PR out of community review
We currently only fetch the default 30 reviews, but rust-lang/rust-clippy#17609 contains 33 reviews (that includes review threads, I didn't knew that but it make sense). Therefor let's fetch the maximum 100 on one API call for now.
We can add a loop in the future if necessary.