Fix sending of Zulip DMs - #2487
Merged
Merged
Conversation
It was unused, so it was confusing that it was implemented.
We should be using IDs instead.
And use the `direct` message kind, as per https://zulip.com/api/send-message#parameter-type.
Urgau
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e-mail field shouldn't really have been used, I removed it and switched to IDs instead. Also migrated the DM message type to
directfromprivate, as per https://zulip.com/api/send-message#parameter-type.Note: according to the documentation, the
tofield for DMs should actually be a list. But it seems that Zulip accepts also just a single value there.