Bubble-up a proper user error instead of swallowing failed assignment - #2483
Merged
Merged
Conversation
Kobzol
approved these changes
Aug 18, 2026
Kobzol
added this pull request to the merge queue
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the assign handler is swallowing failed assignment errors from the surrounding control flow, which means that we post the error but still post the assignments messages and update the DB like the assignment successfully happened, while it didn't.
Instead of that, let's return a
UserErrorfrom the handler so we can properly exit the handler and post only the error.Fixes #2481