Rollup of 6 pull requests by JonathanBrouwer · Pull Request #161685 · rust-lang/rust

JonathanBrouwer · 2026-08-24T17:33:24Z

Successful merges:

stabilize never type #155499 (stabilize never type)
add crashtests [6/N] #161294 (add crashtests [6/N])
Only use dlltool.exe on MinGW if -Cdlltool is passed #161050 (Only use dlltool.exe on MinGW if -Cdlltool is passed)
Add new invalid_markdown_table rustdoc lint #159583 (Add new invalid_markdown_table rustdoc lint)
PassWrapper: handle LLVM 24 change in function types #161098 (PassWrapper: handle LLVM 24 change in function types)
Don't treat slashes as path seps after drive letters in verbatim paths #161661 (Don't treat slashes as path seps after drive letters in verbatim paths)

The linker used by MinGW now works with ar_archive_writer generated short import libraries too.

LLVM 24 stopped using llvm::Any here to avoid heap allocations in PassInstrumentation.

… lint

The essential problem is that, with this table: ```text one | ----| a | b | c a | b | a | b a | ``` And this logic: ```rust let too_many_pipes = divider_count > expected_cells + 1; ``` `expected_cells + 1` winds up as 2, so you get this warning: ```text error: unused content after last table cell --> $DIR/invalid_markdown_table.rs:81:14 | LL | //! a | b | c | ^^^^^^ this content is discarded error: unused content after last table cell --> $DIR/invalid_markdown_table.rs:83:14 | LL | //! a | b | | ^^^^ this content is discarded error: unused content after last table cell --> $DIR/invalid_markdown_table.rs:85:14 | LL | //! a | b | ^^ this content is discarded ``` We really want our warning to give the suggest-escaping flow, like this: ```text error: table row has too many columns --> $DIR/invalid_markdown_table.rs:81:13 | LL | //! a | b | c | ^ any content after this column divider is discarded | = help: to escape `|` characters in tables, add a `\` before them like `\|` error: table row has too many columns --> $DIR/invalid_markdown_table.rs:83:13 | LL | //! a | b | | ^ any content after this column divider is discarded | = help: to escape `|` characters in tables, add a `\` before them like `\|` error: unused content after last table cell --> $DIR/invalid_markdown_table.rs:85:14 | LL | //! a | b | ^^ this content is discarded ``` By only scanning the text between the end of the last cell and the row, instead of doing the entire row, we don't have to re-implement as much of pulldown-cmark's logic.

The reason `rustc_ast_ir` and `rustc_pattern_analysis` have nested `cfg_attr`s is so that they don't mention `cfg(bootstrap)` when nightly or rustc cargo feature turned on. If you don't do it like that, they stop compiling on stable (or rather, they emit unexpected cfg warnings...).

??? why wasn't this detected by compiletest ???

JonathanBrouwer · 2026-08-24T17:33:56Z

@bors r+ p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-1,aarch64-apple-2,x86_64-mingw-1,i686-msvc-1,i686-msvc-2

rust-bors · 2026-08-24T17:34:00Z

📌 Commit d52a696 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 6 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-1 try-job: aarch64-apple-2 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: i686-msvc-2

…uwer Rollup of 6 pull requests Successful merges: - #155499 (stabilize never type) - #161294 (add crashtests [6/N]) - #161050 (Only use dlltool.exe on MinGW if -Cdlltool is passed) - #159583 (Add new `invalid_markdown_table` rustdoc lint) - #161098 (PassWrapper: handle LLVM 24 change in function types) - #161661 (Don't treat slashes as path seps after drive letters in verbatim paths)

rust-bors · 2026-08-24T18:14:05Z

💔 Test for 2845f30 failed: CI. Failed job:

auto - x86_64-gnu-stdlib-semver-check (web logs, enhanced plaintext logs)

rust-bors · 2026-08-24T18:15:51Z

This pull request was unapproved due to being closed.

rust-log-analyzer · 2026-08-24T18:19:15Z

The job x86_64-gnu-stdlib-semver-check failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[endgroup]
[TIMING:end] doc::Std { build_compiler: Compiler { stage: 1, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu, format: Json, crates: [] } -- 47.994
Checking semver compatibility of core
cargo-semver-checks found semver breakage in core
    Checking <unknown> v1.100.0-nightly (0a3fa2af3 2026-08-24) -> v1.100.0-nightly (2845f3031 2026-08-24) (assume minor change)
     Checked [   4.507s] 196 checks: 195 pass, 1 fail, 0 warn, 58 skip

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [   5.868s] <unknown>


--- failure enum_missing: pub enum removed or renamed ---

Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_missing.ron

Failed in:
  enum core::convert::Infallible, previously in file library/core/src/convert/mod.rs:920

Bootstrap failed while executing `test std-semver-check --set rust.stdlib-semver-baseline=0a3fa2af35783dcd1b4206a85fe7811297eea0bf`

Important

For more information how to resolve CI failures of this job, visit this link.

rust-log-analyzer · 2026-08-24T19:50:18Z

The job x86_64-mingw-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[group]Building test helpers for x86_64-pc-windows-gnu
##[endgroup]
[TIMING:end] test::TestHelpers { target: x86_64-pc-windows-gnu } -- 0.145
##[group]Testing stage2 with compiletest suite=ui mode=ui (x86_64-pc-windows-gnu)
FATAL: failed to run "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "-Crpath" "-Cdebuginfo=0" "-Lnative=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\native\\rust-test-helpers" "--print=all-target-specs-json" "-Zunstable-options"
--- stdout

--- stderr


---
Currently active steps:
test::Ui { test_compiler: Compiler { stage: 2, host: x86_64-pc-windows-gnu, forced_compiler: false }, target: x86_64-pc-windows-gnu } at src\bootstrap\src\core\build_steps\test.rs:1943
test::Compiletest { test_compiler: Compiler { stage: 2, host: x86_64-pc-windows-gnu, forced_compiler: false }, target: x86_64-pc-windows-gnu, mode: ui, suite: "ui", path: "tests/ui", compare_mode: None } at src\bootstrap\src\core\build_steps\test.rs:1943
Build completed unsuccessfully in 1:01:36
make: *** [Makefile:126: ci-mingw-x] Error 1
  local time: Mon Aug 24 18:45:10 CUT 2026
  network time: Mon, 24 Aug 2026 18:45:11 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

rust-bors · 2026-08-24T20:38:02Z

💔 Test for a24e717 failed: CI. Failed job:

try - x86_64-mingw-1 (web logs, enhanced plaintext logs)

bjorn3 and others added 30 commits August 14, 2026 11:43

Only use dlltool.exe on MinGW if -Cdlltool is passed

fd82481

The linker used by MinGW now works with ar_archive_writer generated short import libraries too.

PassWrapper: handle LLVM 24 change in function types

299213f

LLVM 24 stopped using llvm::Any here to avoid heap allocations in PassInstrumentation.

PassWrapper: clang-format

50b867f

add crashtests

af7623a

Don't treat slashes as path seps after drive letters in verbatim paths

afcb367

Add new unescaped_pipe_in_table_cell rustdoc lint

97967de

Add ui regression test for new rustdoc unescaped_pipe_in_table_cell…

dbe2c8e

… lint

Add documentation for rustdoc unescaped_pipe_in_table_cell lint

f74d66c

Rename lint unescaped_pipe_in_table_cell into invalid_markdown_table

fe90bb2

Also warn in case there is content after the last table cell

67bfe3a

Update lint to new rustdoc table lint

aeb0d4a

Fix whitespace.

1f7f241

Set never type fallback to always be !

6656056

stabilize the never type (!)

6ed4ce5

fixup clippy::empty_enums

977c3a7

remove #![feature(never_type)] from tests

046ebb7

remove #![feature(never_type)] from library

3de37a2

remove #![feature(never_type)] from tools

00745cc

bless tests

2b466a3

bless mir-opt tests

ab2a410

update tests which depended on never fallback to ()

9b02a7e

remove dependency_on_unit_never_type_fallback lint

11eebd5

remove stray stderr files

e9d08de

??? why wasn't this detected by compiletest ???

make never_type_fallback_flowing_into_unsafe a non-FCW lint

39c6cac

Make Infallible = !

cfc82eb

remove unreachable code

3419a3c

fixup tests to account for Infallible = !

748439c

bless mir-opt tests

b74b72b

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 24, 2026

JonathanBrouwer mentioned this pull request Aug 24, 2026

stabilize never type #155499

Merged

JonathanBrouwer closed this Aug 24, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 24, 2026

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2026

Navigation Menu

Uh oh!

Uh oh!

Rollup of 6 pull requests - #161685

Rollup of 6 pull requests#161685
JonathanBrouwer wants to merge 36 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-Ilv1xfZ

JonathanBrouwer commented Aug 24, 2026

Uh oh!

JonathanBrouwer commented Aug 24, 2026

Uh oh!

rust-bors Bot commented Aug 24, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 24, 2026

Uh oh!

rust-bors Bot commented Aug 24, 2026

Uh oh!

rust-log-analyzer commented Aug 24, 2026

Uh oh!

rust-log-analyzer commented Aug 24, 2026

Uh oh!

rust-bors Bot commented Aug 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Aug 24, 2026

Uh oh!

JonathanBrouwer commented Aug 24, 2026

Uh oh!

rust-bors Bot commented Aug 24, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 24, 2026

Uh oh!

rust-bors Bot commented Aug 24, 2026

Uh oh!

rust-log-analyzer commented Aug 24, 2026

Uh oh!

rust-log-analyzer commented Aug 24, 2026

Uh oh!

rust-bors Bot commented Aug 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants