Add custom allocators to (try_)map on Box, Rc, Arc - #161617
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
maxdexh
force-pushed
the
can-i-has-map-allocator
branch
from
August 23, 2026 19:04
62ce360 to
c158e17
Compare
Member
|
straightforward enough. given that we're just moving around a preexisting method i think it's fair to skip acp on this. @bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 25, 2026
…=nia-e Add custom allocators to `(try_)map` on `Box`, `Rc`, `Arc` Adds custom allocators to `(try_)map` on `Box`, `Rc`, `Arc`. Not on `UniqueArc`/`UniqueRc` because too much allocator-related API is missing atm and I didn't want to end up writing unsound garbage. The `else` branch in those needs to drop a weakref, I'll get to that later. cc rust-lang#160534 r? nia-e
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 25, 2026
…=nia-e Add custom allocators to `(try_)map` on `Box`, `Rc`, `Arc` Adds custom allocators to `(try_)map` on `Box`, `Rc`, `Arc`. Not on `UniqueArc`/`UniqueRc` because too much allocator-related API is missing atm and I didn't want to end up writing unsound garbage. The `else` branch in those needs to drop a weakref, I'll get to that later. cc rust-lang#160534 r? nia-e
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 25, 2026
…=nia-e Add custom allocators to `(try_)map` on `Box`, `Rc`, `Arc` Adds custom allocators to `(try_)map` on `Box`, `Rc`, `Arc`. Not on `UniqueArc`/`UniqueRc` because too much allocator-related API is missing atm and I didn't want to end up writing unsound garbage. The `else` branch in those needs to drop a weakref, I'll get to that later. cc rust-lang#160534 r? nia-e
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 25, 2026
…=nia-e Add custom allocators to `(try_)map` on `Box`, `Rc`, `Arc` Adds custom allocators to `(try_)map` on `Box`, `Rc`, `Arc`. Not on `UniqueArc`/`UniqueRc` because too much allocator-related API is missing atm and I didn't want to end up writing unsound garbage. The `else` branch in those needs to drop a weakref, I'll get to that later. cc rust-lang#160534 r? nia-e
This was referenced Aug 25, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 25, 2026
…uwer Rollup of 13 pull requests Successful merges: - #158874 (hir_ty_lowering: fix anon const type recovery) - #161443 (add internal DSL for testing binders) - #161617 (Add custom allocators to `(try_)map` on `Box`, `Rc`, `Arc`) - #161726 (Fix debugger visualizer tuple child ordering w/ PDB debug info) - #161729 (miri subtree update) - #161745 (make trivial ABI check resilient against new repr) - #160871 (Remove `#[rustc_reservation_impl]`) - #161180 (Detect missing binding available: add a MaybeIncorrect suggestion) - #161522 (test `f16::mul_add` not double-rounding the result) - #161631 (Add two comments relating to new-solver performance) - #161724 (Add codegen test for static table search loop unrolling) - #161740 (do not compress debuginfo for Cygwin) - #161750 (vector ABI check: reword so it makes more sense for non-obviously-vector types)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 25, 2026
Rollup merge of #161617 - maxdexh:can-i-has-map-allocator, r=nia-e Add custom allocators to `(try_)map` on `Box`, `Rc`, `Arc` Adds custom allocators to `(try_)map` on `Box`, `Rc`, `Arc`. Not on `UniqueArc`/`UniqueRc` because too much allocator-related API is missing atm and I didn't want to end up writing unsound garbage. The `else` branch in those needs to drop a weakref, I'll get to that later. cc #160534 r? nia-e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds custom allocators to
(try_)maponBox,Rc,Arc.Not on
UniqueArc/UniqueRcbecause too much allocator-related API is missing atm and I didn't want to end up writing unsound garbage. Theelsebranch in those needs to drop a weakref, I'll get to that later.cc #160534
r? nia-e