Skip to content

Construct paramenvs from an iterator - #161447

Open
jdonszelmann wants to merge 4 commits into
rust-lang:mainfrom
jdonszelmann:paramenv-from-iter
Open

Construct paramenvs from an iterator#161447
jdonszelmann wants to merge 4 commits into
rust-lang:mainfrom
jdonszelmann:paramenv-from-iter

Conversation

@jdonszelmann

@jdonszelmann jdonszelmann commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

r? @lcnr

Change things so paramenvs are created from iterators instead of already interned lists. In theory this may sometimes cause re-interning, but I haven't seen any performance change because of it. The advantage is that doing the interning becomes private API of paramenvs, so we can change how it works (by for example, compressing the paramenv in the future).

Note

I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 21, 2026
@rustbot

rustbot commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jdonszelmann jdonszelmann changed the title Paramenv from iter Construct paramenvs from an iterator Aug 24, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr reviewed Aug 24, 2026
View reviewed changes
Comment thread compiler/rustc_trait_selection/src/traits/specialize/mod.rs Outdated
lcnr
lcnr reviewed Aug 24, 2026
View reviewed changes
Comment thread compiler/rustc_middle/src/ty/mod.rs Outdated
@rustbot

rustbot commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

lcnr
lcnr reviewed Aug 25, 2026
View reviewed changes

@lcnr lcnr left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after nit

View changes since this review

Comment thread compiler/rustc_hir_analysis/src/check/compare_impl_item.rs Outdated
@jdonszelmann

jdonszelmann commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=lcnr

@rust-bors

rust-bors Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0da5e32 has been approved by lcnr

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 25, 2026
@jdonszelmann

jdonszelmann commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@bors rollup

@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 25, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161447 - jdonszelmann:paramenv-from-iter, r…
9bedded 
…=lcnr

Construct paramenvs from an iterator

r? @lcnr

Change things so paramenvs are created from iterators instead of already interned lists. In theory this may sometimes cause re-interning, but I haven't seen any performance change because of it. The advantage is that doing the interning becomes private API of paramenvs, so we can change how it works (by for example, compressing the paramenv in the future).

> [!NOTE]
> I've not used an LLM for any part of this PR, or any other PR I make. This includes any related work like research.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 25, 2026
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdonszelmann

jdonszelmann commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@bors r-

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 25, 2026
@rust-bors

rust-bors Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#161752), which was unapproved.

View changes since this unapproval

@jdonszelmann

jdonszelmann commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

oh that's nasty but makes so much sense, oof

@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnr lcnr lcnr left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@lcnr lcnr

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jdonszelmann @rustbot @rust-log-analyzer @lcnr