[beta] bump stage0, plus backports

[cuviper]

• Bump stage0 to stable 1.98.0
• fix buggy MaybeDangling<&T> validation logic fix buggy MaybeDangling<&T> validation logic #161125
• resolving cyclic glob vis-max resolving cyclic glob vis-max #161024
• Check for missing rustfmt in the stdarch intrinsic test step sooner Check for missing rustfmt in the stdarch intrinsic test step sooner #161641

r? me

[rustbot]

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

[cuviper]

@bors r+ rollup=never

[rust-bors]

📌 Commit 043ef18 has been approved by cuviper

It is now in the queue for this repository.

[rust-bors]

💔 Test for b18e17a failed: CI. Failed job:

• auto - aarch64-gnu (web logs, enhanced plaintext logs)

[cuviper]

WARNING: intrinsic-test skipped because rustfmt is required but not available on this channel
[TIMING:start] format::InternalRustfmt {  }
[TIMING:end] format::InternalRustfmt {  } -- 0.000

thread 'main' (1407) panicked at src/build_helper/src/drop_bomb/mod.rs:47:13:
command constructed at `src/bootstrap/src/core/build_steps/tool.rs:1607:23` was dropped without being executed: `/checkout/obj/build/aarch64-unknown-linux-gnu/stage1-tools-bin/intrinsic-test`

That WARNING has an early return per #159265 (@xonx4l, @Kobzol), but it looks like it should defuse the command too. Even better, it could go way up near the target check, so it's before any filesystem modification.

[Kobzol]

Indeed, the check should be at the top of the function. #161641 should fix this.

[cuviper]

@bors try jobs=aarch64-gnu

[rust-bors]

☀️ Try build successful (CI)
Build commit: eeed4ad (eeed4adb66e2938705ce075379bf69a9a3d3e235)
Base parent: f47d5bb (f47d5bb13648d5c859f5b438eb7dc834b9729961)

[cuviper]

@bors r+

[rust-bors]

📌 Commit 908f2ad has been approved by cuviper

It is now in the queue for this repository.

[rust-bors]

💔 Test for b4777f2 failed: CI. Failed job:

• auto - dist-x86_64-linux (web logs, enhanced plaintext logs)