Skip to content

Add regression test for cross crate specialization query cycle - #161395

Closed
zakrad wants to merge 1 commit into
rust-lang:mainfrom
zakrad:regr-test-90817
Closed

Add regression test for cross crate specialization query cycle#161395
zakrad wants to merge 1 commit into
rust-lang:mainfrom
zakrad:regr-test-90817

Conversation

@zakrad

@zakrad zakrad commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Closes #90817

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 20, 2026
@rustbot

rustbot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 16 candidates

@tiif

tiif commented Aug 22, 2026

Copy link
Copy Markdown
Member

r? me

@rustbot rustbot assigned tiif and unassigned fee1-dead Aug 22, 2026
@tiif

tiif commented Aug 22, 2026

Copy link
Copy Markdown
Member

Upon some digging, #90817 seems to be a duplication of #125197. The issue is fixed in #126139, and there is already a test added for it. But thank you for your contribution regardless!

@tiif tiif closed this Aug 22, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2026
@zakrad
zakrad deleted the regr-test-90817 branch August 22, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cycle detected when computing whether impls specialize one another, across crate boundaries

4 participants