Remove #[rustc_reservation_impl] - #160871
Conversation
This comment has been minimized.
This comment has been minimized.
dc47214 to
5bb1e02
Compare
|
The use case I described for I think it's fine to remove this specific hack and later replace it with something else if it happens to use the same name. |
This comment has been minimized.
This comment has been minimized.
5bb1e02 to
15f38ce
Compare
This comment has been minimized.
This comment has been minimized.
15f38ce to
7c1e726
Compare
|
This PR changes rustc_public cc @oli-obk, @celinval, @ouz-a, @makai410 Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_ir |
Based on #160705.
There was only ever one reservation impl and it got (/is being) removed in #160705. I don't think there is a reason to keep the machinery, given how specific and tricky the semantics of it are (see #64631).
Closes #64631.
cc @clarfonthey since you seem to have found another use for the attribute (#64631 (comment)) (I haven't looked into it, so not sure if it might be worth keeping the attribute for that use case).
r? types