Skip to content

add target feature ABI checks for SPARC - #160562

Open
RalfJung wants to merge 1 commit into
rust-lang:mainfrom
RalfJung:sparc
Open

add target feature ABI checks for SPARC#160562
RalfJung wants to merge 1 commit into
rust-lang:mainfrom
RalfJung:sparc

Conversation

@RalfJung

@RalfJung RalfJung commented Aug 5, 2026

Copy link
Copy Markdown
Member

@rustbot

rustbot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2026
@rustbot

rustbot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

@rust-log-analyzer

This comment has been minimized.

@RalfJung

RalfJung commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

Ah, the sparc-unknown-linux-gnu target enables v8plus... that's a bit surprising given that I was told that the ABI isn't actually implemented in LLVM yet?
This is also a tier 3 target without a listed target maintainer, so I feel inclined to just remove the target feature from the target spec.

Comment thread compiler/rustc_target/src/target_features.rs Outdated
Comment thread compiler/rustc_target/src/target_features.rs
VecDefault = "vec-default",
VecExtAbi = "vec-extabi",
X32 = "x32",
V8Plus = "v8plus",

@RalfJung RalfJung Aug 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any kind of process for a new cfg value here?

View changes since the review

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-log-analyzer

This comment has been minimized.

@fee1-dead

Copy link
Copy Markdown
Member

@rustbot reroll

@rustbot rustbot assigned chenyukang and unassigned fee1-dead Aug 9, 2026
@chenyukang

Copy link
Copy Markdown
Member

@rustbot reroll

@rustbot rustbot assigned hanna-kruppe and unassigned chenyukang Aug 10, 2026
@hanna-kruppe

Copy link
Copy Markdown
Contributor

I don't really know anything about SPARC nor have I touched the compiler machinery for these checks yet. Maybe one of the people pinged earlier wants to take this? If not, I guess that's my chance to learn some more funny cursed trivia, but it'll take a while.

@RalfJung RalfJung added the S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. label Aug 16, 2026
@rust-bors

This comment has been minimized.

@rustbot

rustbot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot

rustbot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing target feature ABI checks for Sparc64

8 participants