leak_check in rustc_const_eval::util::relate_types - #155883
Open
lcnr wants to merge 1 commit into
Open
Conversation
Collaborator
rustbot
added
S-waiting-on-review
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
Apr 27, 2026
| impl Trait for F1 { | ||
| type Assoc = i64; | ||
| } | ||
| #[expect(coherence_leak_check)] |
Member
There was a problem hiding this comment.
What does this do...?
Contributor
Author
There was a problem hiding this comment.
it expects the coherence_leak_check lint. That lint is in a horrible state but fixing the lint doesn't seem too useful given that this thing is currently still in flux and updating it properly is non-trivial 😅
Member
There was a problem hiding this comment.
Ah, your fix makes this code emit a lint (#56105). That doesn't seem to make much sense but 🤷 sure whatever.
RalfJung
reviewed
Apr 27, 2026
RalfJung
reviewed
Apr 27, 2026
lcnr
force-pushed
the
relate_types-leak-check
branch
from
April 27, 2026 15:35
de223eb to
715e75d
Compare
Member
|
r=me based on the tests passing. Up to you if you want to get a review from someone who actually knows what all these type system queries do. ;) |
RalfJung
reviewed
Apr 27, 2026
| ocx.evaluate_obligations_error_on_ambiguity().is_empty() | ||
|
|
||
| if ocx.evaluate_obligations_error_on_ambiguity().is_empty() { | ||
| infcx.leak_check(ty::UniverseIndex::ROOT, None).is_ok() |
Member
There was a problem hiding this comment.
Suggested change
| infcx.leak_check(ty::UniverseIndex::ROOT, None).is_ok() | |
| // Ensure there are no pending lifetime constraints. This is needed to avoid issues like | |
| // <https://github.com/rust-lang/rust/issues/155477>. | |
| infcx.leak_check(ty::UniverseIndex::ROOT, None).is_ok() |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
looks like this exposes a place where validation uses equality instead of subtyping? don't have the time to look into that rn, but prolly just need to change the variance/used function at the place where this ICEs |
Member
|
@rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
affected test with just fn foo(_: &str) {}
fn main() {
let lhs = foo as fn(&'static str);
let rhs = foo as for<'a> fn(&'a str);
let _ = lhs == rhs;
} |
Contributor
Author
|
looking at the MIR https://gist.github.com/lcnr/0b3dde206b3c47989e30a9bbcfbdc3cf we just equate MIR validation then checks whether |
lcnr
force-pushed
the
relate_types-leak-check
branch
from
August 25, 2026 10:01
715e75d to
d475155
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
started a zulip thread for this as I don't have the capacity to impl this myself https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/subtyping.20in.20MIR.20building.20for.20builtin.20binary.20ops/with/618977123 |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #155477. we should really figure out an API where people don't have to manually call
leak_checkfor their code to be correct. I don't really know what that API should be for now, but the status quo sucks xxsame issue was recently fixed when checking that the return type of
fn mainimplementsTerminationin #151377r? BoxyUwU