Skip to content

Recover feature lang_items for emscripten - #153128

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mu001999-contrib:fix/features
Feb 28, 2026
Merged

Recover feature lang_items for emscripten#153128
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mu001999-contrib:fix/features

Conversation

@mu001999

Copy link
Copy Markdown
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 26, 2026
@rustbot

rustbot commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, joboet

@joboet

joboet commented Feb 26, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d79efc5 has been approved by joboet

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2026
@rust-bors
rust-bors Bot merged commit 5bb3260 into rust-lang:main Feb 28, 2026
@rustbot rustbot added this to the 1.95.0 milestone Feb 28, 2026
#![no_std]
#![unstable(feature = "panic_unwind", issue = "32837")]
#![doc(issue_tracker_base_url = "https://github.com/rust-lang/rust/issues/")]
#![cfg_attr(all(target_os = "emscripten", not(emscripten_wasm_eh)), lang_items)]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be:

Suggested change
#![cfg_attr(all(target_os = "emscripten", not(emscripten_wasm_eh)), lang_items)]
#![cfg_attr(all(target_os = "emscripten", not(emscripten_wasm_eh)), feature(lang_items))]

(untested)

See:

error: cannot find attribute `lang_items` in this scope
  --> /rustc/38c0de8dcb14d42290042521be9958d37f3fa390/library/panic_unwind/src/lib.rs:17:69
   |
17 | #![cfg_attr(all(target_os = "emscripten", not(emscripten_wasm_eh)), lang_items)]
   |                                                                     ^^^^^^^^^^

error[E0658]: lang items are subject to change
  --> /rustc/38c0de8dcb14d42290042521be9958d37f3fa390/library/panic_unwind/src/emcc.rs:40:1
   |
40 | #[lang = "eh_catch_typeinfo"]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: add `#![feature(lang_items)]` to the crate attributes to enable
   = note: this compiler was built on 2026-02-28; consider upgrading it if it is out of date

For more information about this error, try `rustc --explain E0658`.
error: could not compile `panic_unwind` (lib) due to 2 previous errors

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awkward😅

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops... 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants