Rollup of 2 pull requests - #152678
Closed
JonathanBrouwer wants to merge 6 commits into
Closed
Conversation
Unlike other systems, Windows requires runtime libraries to be present in `PATH` or right next to the binary. So, we copy the library next to the binary as the easier solution.
Install LLVM DLL in the right place on Windows Continuation of rust-lang#151795 towards rust-lang#151774. Unlike other systems, Windows requires runtime libraries to be present in `PATH` or right next to the binary. So, we copy the library next to the binary as the easier solution. Tested building `rust-openssl` in debug and release modes, but the difference is within noise margin.
feat: show what lint was overruled We can't `#[allow]` a whole lint group if any of its members is forbidden, but the offending member is not currently shown if it was forbidden from the command line. Before/after: ```diff $ rustc -F dead_code - <<< '#![allow(unused)]' error[E0453]: allow(unused) incompatible with previous forbid --> <anon>:1:10 | 1 | #![allow(unused)] | ^^^^^^ overruled by previous forbid | - = note: `forbid` lint level was set on command line + = note: `forbid` lint level was set on command line (`-F dead_code`) error: aborting due to 1 previous error ``` @rustbot label +A-diagnostics +A-lints +D-terse
rustbot
added
A-CI
Member
Author
|
@bors r+ rollup=never p=5 |
rustbot
added
T-compiler
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
PR #152609, which is a member of this rollup, was unapproved. |
rust-bors
Bot
removed
the
S-waiting-on-bors
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
r? @ghost
Create a similar rollup