Add allow-panic-in-result-fn-in-tests configuration - #17516
Open
dcsommer wants to merge 1 commit into
Open
Conversation
dcsommer
force-pushed
the
master
branch
3 times, most recently
from
August 7, 2026 15:25
7e677ee to
c8932dc
Compare
Add a dedicated test exemption for `panic_in_result_fn` rather than broadening `allow-panic-in-tests`, since this lint also covers assertions. Apply it to test functions and code under `#[cfg(test)]`. changelog: [`panic_in_result_fn`]: add `allow-panic-in-result-fn-in-tests` to allow panics and assertions in tests
dcsommer
marked this pull request as ready for review
August 7, 2026 16:43
rustbot
added
S-waiting-on-review
4 tasks
Author
|
Note, I'd prefer to ship #17520 -- this PR is only a backup in case that is not accepted. |
Collaborator
|
☔ The latest upstream changes (possibly #17607) made this pull request unmergeable. Please resolve the merge conflicts. |
CommanderStorm
suggested changes
Aug 23, 2026
Comment on lines
+89
to
+90
| if !(is_inside_always_const_context(cx.tcx, e.hir_id) | ||
| || allow_panic_in_result_fn_in_tests && is_in_test(cx.tcx, e.hir_id)) |
Contributor
There was a problem hiding this comment.
is this bracketed the way you want? Did you not intend this?
likely with some extracting of variables, because the brackets are getting overbearing.
Suggested change
| if !(is_inside_always_const_context(cx.tcx, e.hir_id) | |
| || allow_panic_in_result_fn_in_tests && is_in_test(cx.tcx, e.hir_id)) | |
| if (!(is_inside_always_const_context(cx.tcx, e.hir_id) | |
| || (allow_panic_in_result_fn_in_tests && is_in_test(cx.tcx, e.hir_id)))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this PR was drafted with Opus 5. I (the human) reviewed all content, including by-hand fixes, prior to submission.
changelog: [
panic_in_result_fn]: addallow-panic-in-result-fn-in-teststo allow panics and assertions in testsallow-panic-in-testsonly configures thepaniclint and does notsuppress
panic_in_result_fn.Add a dedicated
allow-panic-in-result-fn-in-testsconfiguration option. It uses the same expression-level test detection as the otherallow-*-in-testsoptions and coverspanic!,assert!,assert_eq!, andassert_ne!.This intentionally retains the existing behavior for integration tests and benchmarks, which are compiled as ordinary targets rather than
#[cfg(test)]code.