feat: Add profile-specific configuration for disallowed methods and t… - #17301
feat: Add profile-specific configuration for disallowed methods and t…#17301Lallapallooza wants to merge 1 commit into
Conversation
|
rustbot has assigned @samueltardieu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
This lint has been nominated for inclusion. |
|
@Jarcho Hi, are there any updates on FCP? |
This comment has been minimized.
This comment has been minimized.
|
@Jarcho @blyxyas @samueltardieu Hello, are there any updates on FCP? |
…ypes Add profile-scoped disallow lists for methods and types, wiring the new configuration tables through a shared resolver that can be toggled with - extend clippy_config::Conf to parse [profiles.*] tables with per-profile disallowed-methods and disallowed-types entries through reusable helpers - introduce clippy_utils::disallowed_profiles to resolve #[clippy::disallowed_profile(s)] attributes with caching, diagnostics for bad inputs, and shared symbol registrations - teach DisallowedMethods and DisallowedTypes to honor active profiles, reuse the combined profile set, and annotate diagnostics with the triggering profile name - add UI TOML coverage for per-profile behavior and refresh the unknown-key fixture for the new configuration entries - register the new attributes and symbols so tool attributes remain recognized and pedantic lints stay clean changelog: [disallowed_methods]: allow selecting per-scope disallow lists via [profiles.*] and the clippy::disallowed_profile attribute changelog: [disallowed_types]: allow selecting per-scope disallow lists via [profiles.*] and the clippy::disallowed_profile attribute
3f4218b to
c151a22
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@Jarcho @blyxyas @samueltardieu Where this stands:
I'm not asking for a merge, I'm asking for a decision. If something is blocking it, I'd like to know what. |
|
Hi @Lallapallooza, I'm sorry for all these delays. We've had a real reviewer shortage, which was greatly exacerbated by your proposal being a big one. I appreciate a lot the effort you've put into this, and I want to see it being merged. The FCP process is simply because at one point we had too many lints, and had to implement some friction between big changes being made to avoid tech debt being merged too quickly. I've had my resources to work on Clippy greatly improved, so I'll be taking more care of your feature from now on. Again, sorry for the delays, due to the volunteer-based nature of the project, these things sometimes happen. |
|
If you want to participate in the FCP judging process, it's open and public here https://rust-lang.zulipchat.com/#narrow/channel/577190-t-clippy.2Ffcp/topic/FCP.20rust-clippy.2317301.3A.20feat.3A.20Add.20profile-specific.20configura.E2.80.A6/with/614807707 |
|
☔ The latest upstream changes (possibly #17607) made this pull request unmergeable. Please resolve the merge conflicts. |
Add profile-scoped disallow lists for methods and types, wiring the new configuration tables through a shared resolver that can be toggled with #[clippy::disallowed_profile] attributes.
changelog: [disallowed_methods]: allow selecting per-scope disallow lists via [profiles.] and the clippy::disallowed_profile attribute changelog: [disallowed_types]: allow selecting per-scope disallow lists via [profiles.] and the clippy::disallowed_profile attribute