Implement unnecessary bitmask on cast lint#17188
Open
Francisco-Andre-Martins wants to merge 1 commit into
Open
Implement unnecessary bitmask on cast lint#17188Francisco-Andre-Martins wants to merge 1 commit into
Francisco-Andre-Martins wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dswij (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
|
Lintcheck changes for 5a63501
This comment will be updated if you push new changes |
d589ee9 to
9afc7cd
Compare
This comment has been minimized.
This comment has been minimized.
When downcasting from a large integer type (like u_64) to a smaller type (like u_8), the rust compiler automatically truncates the integer adequately. Still, some people do decide to perform a bitwise and before casting, essentially truncating the input before it is cast. Closes rust-lang#16125 Co-authored-by: Guilherme Silva <guilherme.d.silva@tecnico.ulisboa.pt>
9afc7cd to
5a63501
Compare
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When downcasting from a large integer type (like u_64) to a smaller type (like u_8), the rust compiler
automatically truncates the integer adequately.
Still, some people do decide to perform a bitwise
and before casting, essentially truncating
the input before it is cast.
Closes #16125
changelog: Implement needless bitmask lint