Implement redundant idempotent calls lint#17187
Open
Francisco-Andre-Martins wants to merge 2 commits into
Open
Implement redundant idempotent calls lint#17187Francisco-Andre-Martins wants to merge 2 commits into
Francisco-Andre-Martins wants to merge 2 commits into
Conversation
When a method that is idempotent (calling it multiple times produces the same result as calling it once) is called on a value that has already had the same method applied with the same arguments, the second call is redundant and can be removed. Examples of idempotent methods: 'to_lowercase', 'to_uppercase', 'trim', 'trim_start', 'trim_end', 'abs', 'floor', 'ceil', 'round', 'max', 'min', 'clamp', 'and', 'or', 'to_vec', 'to_ascii_lowercase', 'to_ascii_uppercase', 'signum'. Some methods were left out as a possible follow-up, either because each call wraps the value in a new iterator adapter rather than being a true idempotent, because they have side effects, or because they are only idempotent under very specific conditions. Closes rust-lang#16099 Co-authored-by: Guilherme Silva <guilherme.d.silva@tecnico.ulisboa.pt>
rustbot
added
needs-fcp
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @samueltardieu (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
|
Lintcheck changes for 0b846fb
This comment will be updated if you push new changes |
Member
|
Tests need to pass (including "dogfood") @rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Contributor
|
Yup, sorry for the inconvenient, it should be ready now. |
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a method that is idempotent (calling it multiple times produces the same result as calling it once) is called on a value that has already had the same method applied with the same arguments, the second call is redundant and can be removed.
Examples of idempotent methods: 'to_lowercase', 'to_uppercase', 'trim', 'trim_start', 'trim_end', 'abs', 'floor', 'ceil', 'round', 'max', 'min', 'clamp', 'and', 'or', 'to_vec', 'to_ascii_lowercase', 'to_ascii_uppercase', 'signum'.
Some methods were left out as a possible follow-up, either because each call wraps the value in a new iterator adapter rather than being a true idempotent, because they have side effects, or because they are only idempotent under very specific conditions.
Closes #16099
changelog: implement redundant idempotent call lint