Skip to content

Move clippy::exit into methods#17106

Draft
samueltardieu wants to merge 2 commits into
rust-lang:masterfrom
samueltardieu:cleanup/move-exit-to-method
Draft

Move clippy::exit into methods#17106
samueltardieu wants to merge 2 commits into
rust-lang:masterfrom
samueltardieu:cleanup/move-exit-to-method

Conversation

@samueltardieu

Copy link
Copy Markdown
Member

changelog: none

@rustbot rustbot added the needs-fcp PRs that add, remove, or rename lints and need an FCP label May 28, 2026
@samueltardieu

Copy link
Copy Markdown
Member Author

To be merged after #17105

@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown

No changes for 61065ed

@samueltardieu samueltardieu force-pushed the cleanup/move-exit-to-method branch from cf37997 to 0e02f8a Compare May 28, 2026 12:27
@ada4a

ada4a commented May 31, 2026

Copy link
Copy Markdown
Contributor

Moving a lint that's explicitly not about methods under methods sounds strange to me...

@samueltardieu

Copy link
Copy Markdown
Member Author

Moving a lint that's explicitly not about methods under methods sounds strange to me...

methods is badly named and also checks for function calls.

@ada4a

ada4a commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Should we rename it to calls then maybe?

@samueltardieu

Copy link
Copy Markdown
Member Author

Either that, or introduce a funcalls module, similar to methods, or move fun calls into the functions module.

But also note that the functions module checks for methods, such as in the misnamed_getters lint.

@rustbot

This comment has been minimized.

@samueltardieu samueltardieu force-pushed the cleanup/move-exit-to-method branch from 0e02f8a to 61065ed Compare June 1, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-fcp PRs that add, remove, or rename lints and need an FCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants