Skip to content

Remove PROFILE forwarding from build.rs#17077

Merged
Jarcho merged 1 commit into
rust-lang:masterfrom
Jarcho:profile_fwd
Jun 10, 2026
Merged

Remove PROFILE forwarding from build.rs#17077
Jarcho merged 1 commit into
rust-lang:masterfrom
Jarcho:profile_fwd

Conversation

@Jarcho

@Jarcho Jarcho commented May 27, 2026

Copy link
Copy Markdown
Contributor

compile_test.rs has retrieved the binary path this way for a while now.

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 27, 2026
@rustbot

rustbot commented May 27, 2026

Copy link
Copy Markdown
Collaborator

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 8 candidates
  • 8 candidates expanded to 8 candidates
  • Random selection from ada4a, dswij, llogiq, samueltardieu

@samueltardieu samueltardieu added this pull request to the merge queue May 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 28, 2026
@samueltardieu

Copy link
Copy Markdown
Member

@samueltardieu samueltardieu assigned samueltardieu and unassigned dswij May 28, 2026
Comment thread tests/integration.rs Outdated
let clippy_binary = target_dir.join(env!("PROFILE")).join(CARGO_CLIPPY);

let output = Command::new(clippy_binary)
let output = Command::new(env!("CARGO_BIN_EXE_clippy-driver"))

@samueltardieu samueltardieu May 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let output = Command::new(env!("CARGO_BIN_EXE_clippy-driver"))
let output = Command::new(env!("CARGO_BIN_EXE_cargo-clippy"))

View changes since the review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels May 28, 2026
@rustbot

rustbot commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot

rustbot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Jarcho Jarcho enabled auto-merge June 10, 2026 16:16
@Jarcho Jarcho disabled auto-merge June 10, 2026 16:16
@Jarcho Jarcho enabled auto-merge June 10, 2026 16:17
@Jarcho Jarcho added this pull request to the merge queue Jun 10, 2026
Merged via the queue into rust-lang:master with commit bfe323a Jun 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants