Skip to content

Remove conservative_impl_trait feature - #365

Closed
cramertj wants to merge 1 commit into
rust-lang:masterfrom
cramertj:master
Closed

Remove conservative_impl_trait feature#365
cramertj wants to merge 1 commit into
rust-lang:masterfrom
cramertj:master

Conversation

@cramertj

Copy link
Copy Markdown
Member

This is needed to land the stabilization of impl Trait

cc rust-lang/rust#49255 (comment)

r? @oli-obk

This is needed to land the stabilization of impl Trait
@solson

solson commented Mar 26, 2018

Copy link
Copy Markdown
Contributor

As @oli-obk mentioned on the other thread, Miri's build has been broken for a while anyway so this shouldn't block the stabilization, but thanks for the PR. :)

I can't actually merge it without skipping our required CI build, so we'll need to wait on #364 anyway (or merge this into that).

@cramertj

cramertj commented Mar 26, 2018

Copy link
Copy Markdown
Member Author

Yup, sorry-- this isn't how we'd do this anyway (it'd be better to allow(stable_features) so that it builds with and without the feature)

@cramertj cramertj closed this Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants