Skip to content

Fix previous-chapter nav hover overlapping sidebar resize handle#3134

Merged
ehuss merged 2 commits into
rust-lang:masterfrom
sharksforarms:sharksforarms/nav-hover
Jun 23, 2026
Merged

Fix previous-chapter nav hover overlapping sidebar resize handle#3134
ehuss merged 2 commits into
rust-lang:masterfrom
sharksforarms:sharksforarms/nav-hover

Conversation

@sharksforarms

@sharksforarms sharksforarms commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

The nav arrow is position:fixed and starts at the sidebar's right edge, but the resize handle indicator dots protrude 8px beyond the sidebar. The nav's hover background was painting over that zone, hiding the dots.

Adding margin-inline-start equal to the resize indicator width pushes the nav just past the handle so the two no longer overlap.

Before/After:
Screenshot from 2026-06-10 10-49-31
image

Before/After:
Screenshot from 2026-06-10 11-00-25 Screenshot from 2026-06-10 11-02-03

The nav arrow is position:fixed and starts at the sidebar's right edge,
but the resize handle indicator dots protrude 8px beyond the sidebar.
The nav's hover background was painting over that zone, hiding the dots.

Adding margin-inline-start equal to the resize indicator width pushes
the nav just past the handle so the two no longer overlap.
@sharksforarms sharksforarms marked this pull request as ready for review June 10, 2026 15:16
@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Jun 10, 2026

@ehuss ehuss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I pushed a small update to add a comment explaining what it is doing.

There are some minor things, like this adds a margin even when the sidebar is hidden. However, the right "next" arrow also has a small margin. Also, when javascript is disabled, there is no resize indicator. However, I don't think it will be a problem.

View changes since this review

@ehuss ehuss added this pull request to the merge queue Jun 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 23, 2026
@ehuss ehuss added this pull request to the merge queue Jun 23, 2026
Merged via the queue into rust-lang:master with commit cb49cc5 Jun 23, 2026
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: waiting on a review label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants