use <div role="note"> instead of <blockquote> for admonitions#3027
Open
orangecms wants to merge 1 commit into
Open
use <div role="note"> instead of <blockquote> for admonitions#3027orangecms wants to merge 1 commit into
orangecms wants to merge 1 commit into
Conversation
Also, render the 'title' in a <span> instead of a <p>. This is semantically closer to what assistive tooling supports. For reference, see also: - https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/note_role - https://www.w3.org/TR/WCAG21/#name-role-value (even has a note) Signed-off-by: Daniel Maslowski <info@orangecms.org>
Contributor
Author
|
I also filed this against the underlying parser: |
Contributor
|
Seems reasonable. I'm trying to think about this being somewhat of a breaking change since people may have custom styling that would then break. I'll think about it more, but this may need to wait for 0.6. |
Collaborator
|
☔ The latest upstream changes (possibly 0e6c5d0) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, render the 'title' in a
<span>instead of a<p>. This is semantically closer to what assistive tooling supports. For reference, see also:see #3026