Fix sidebar links to use absolute paths to prevent 404 errors#2730
Closed
madyankin wants to merge 1 commit into
Closed
Fix sidebar links to use absolute paths to prevent 404 errors#2730madyankin wants to merge 1 commit into
madyankin wants to merge 1 commit into
Conversation
This change makes all sidebar navigation links absolute paths (starting with '/') instead of relative paths, preventing duplicate path segments when navigating between nested pages. Added test to verify all sidebar links are absolute paths. Fixes rust-lang#1764
Contributor
|
I don't think this approach will work, since the book may not be rooted at any specific URL path. I believe something more along the lines of #1802. |
Contributor
|
I'm going to close as I don't think this approach will work. Thanks, though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes all sidebar navigation links absolute paths (starting with '/') instead of relative paths, preventing duplicate path segments when navigating between nested pages.
Added test to verify all sidebar links are absolute paths.
Fixes #1764