crate: expose cfg for general 64-bit time_t functionality - #5411
Open
dybucc wants to merge 1 commit into
Open
Conversation
Add `cfg` enabling `time64` functionality across all supported targets. This ensures users have a simple entry point to the crate functionality gated behind one of `linux_time_bits64`, `uclibc_time64` and `gnu_time_bits64`.
rustbot
added
S-waiting-on-review
stable-nominated
tgross35
requested changes
Aug 25, 2026
Comment on lines
187
to
196
| if musl && musl_v1_2 { | ||
| set_cfg("musl_v1_2"); | ||
| if target_ptr_width == "32" { | ||
| set_cfg("musl32_time64"); | ||
| set_cfg("linux_time_bits64"); | ||
| } | ||
| if MUSL_REDIR_TIME64_ARCHES.contains(&target_arch.as_str()) { | ||
| set_cfg("musl_redir_time64"); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This should also set the musl_v1_2 flag, since that's pretty much all it's gating
Comment on lines
+43
to
+45
| // Global flag to enable one of `linux_time_bits64` or `gnu_time_bits64`. | ||
| // The musl flags are enabled by default on supported platforms. | ||
| "time64", |
Member
There was a problem hiding this comment.
I think this isn't actually needed, this list is only for what gets sent to check-cfg and we won't use time64 directly (at least for now)
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch adds support for a new
cfgthat should allow easilytoggling support for 64-bit
time_tin supported platforms. Thisshould make testing of this unstable feature flag in downstream crates
easier than having to manually set up the equivalent
cfgs for anyone of
linux_time_bits64,gnu_time_bits64oruclibc_time64.Note support for the equivalent flag in musl has not been included
because we already have set-up automatic detection and toggling of the
corresponding
cfgunder supported targets 1.Checklist
libc-test/semverhave been updated*LASTor*MAXhave thestandard doc comment
cargo test -p libc-test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated
Footnotes
https://github.com/rust-lang/libc/blob/1a8e71f33b1d6ea1e072210e7fc994417bbb2e34/build.rs#L181-L190 ↩