macros: forward cfg attributes to generated impls - #5372
Open
telcharr wants to merge 2 commits into
Open
Conversation
rustbot
added
S-waiting-on-review
stable-nominated
tgross35
reviewed
Aug 25, 2026
| // The opposite of the configured-out types in `macro_checks`. With the `cfg` true the | ||
| // type and its `Default` both exist, and the other attributes still apply. | ||
| s_with_default! { | ||
| #[cfg(not(any()))] |
Member
There was a problem hiding this comment.
Can this and other tests use cfg(false), or does the MSRV check yell at that? If so, it's nicer to read than any()/not(any)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #5257 for the
cfgissue that was spotted, plus the same onDebugfor unions.Attributes are now split into
cfg_attrsandother_attrs, both go on the type, only thecfgs repeat on the impl. Needed them asttrather thanmetasocfgis still matchable.The generated impls also warn when the type or its fields are deprecated.
s_no_extra_traits!got anallow(deprecated)for that but the newer macros never picked it up.The splitting arms are duplicated between
union_with_debug!andstruct_with_default!. Sharing them needs a callback macro which felt worse to read, but let me know if you'd rather have that.Checklist
libc-test/semverhave been updated*LASTor*MAXhave the standarddoc comment
cargo test -p libc-test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated