Skip to content

Link queued crates to exact versions #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bortlesboat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Link queued crates to exact versions #3408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions crates/bin/docs_rs_web/src/handlers/releases.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1849,6 +1849,12 @@ mod tests {
let a = li.as_node().select_first("a").expect("missing link");
assert!(a.text_contents().contains(expected.0));
assert!(a.text_contents().contains(&expected.1.to_string()));
assert_eq!(
a.attributes.borrow().get("href"),
Some(
format!("https://crates.io/crates/{}/{}", expected.0, expected.1).as_str()
)
);

if let Some(priority) = expected.2 {
assert!(
Expand Down Expand Up @@ -2001,6 +2007,17 @@ mod tests {

assert_eq!(build_queue_list.len(), 1);
assert_eq!(rebuild_queue_list.len(), 2);
for li in build_queue_list.iter().chain(&rebuild_queue_list) {
let a = li.as_node().select_first("a").expect("missing link");
let text = a.text_contents();
let mut parts = text.split_whitespace();
let name = parts.next().expect("missing crate name");
let version = parts.next().expect("missing crate version");
assert_eq!(
a.attributes.borrow().get("href"),
Some(format!("https://crates.io/crates/{name}/{version}").as_str())
);
}
assert!(
rebuild_queue_list
.iter()
Expand Down
4 changes: 2 additions & 2 deletions crates/bin/docs_rs_web/templates/releases/build_queue.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
{%- if !queue.is_empty() -%}
{% for crate_item in queue -%}
<li>
<a href="https://crates.io/crates/{{ crate_item.name }}">
<a href="https://crates.io/crates/{{ crate_item.name }}/{{ crate_item.version }}">
{{- crate_item.name }} {{ crate_item.version -}}
</a>

Expand Down Expand Up @@ -116,7 +116,7 @@
{%- if !rebuild_queue.is_empty() -%}
{% for crate_item in rebuild_queue -%}
<li>
<a href="https://crates.io/crates/{{ crate_item.name }}">
<a href="https://crates.io/crates/{{ crate_item.name }}/{{ crate_item.version }}">
{{- crate_item.name }} {{ crate_item.version -}}
</a>
</li>
Expand Down
Loading