Skip to content

gui-tests: freeze puppeteer version, switch to puppeteer provided chromium#3401

Merged
GuillaumeGomez merged 2 commits into
rust-lang:mainfrom
syphar:fix-gui-test
Jul 8, 2026
Merged

gui-tests: freeze puppeteer version, switch to puppeteer provided chromium#3401
GuillaumeGomez merged 2 commits into
rust-lang:mainfrom
syphar:fix-gui-test

Conversation

@syphar

@syphar syphar commented Jul 7, 2026

Copy link
Copy Markdown
Member

this should fix the gui-tests, while keeping the stable environment.

Everything JS / node related is just improvised, feel free to provide a better way.

@syphar syphar self-assigned this Jul 7, 2026
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jul 7, 2026
Comment thread package.json
@syphar syphar changed the title gui-tests: don't run as root gui-tests: freeze puppeteer version, switch to puppeteer provided chromium Jul 7, 2026
@syphar syphar marked this pull request as ready for review July 7, 2026 11:31
@syphar syphar requested a review from a team as a code owner July 7, 2026 11:31
@syphar syphar requested a review from GuillaumeGomez July 7, 2026 11:31
Comment thread package-lock.json Outdated
@GuillaumeGomez

Copy link
Copy Markdown
Member

Nice, thanks!

@GuillaumeGomez GuillaumeGomez enabled auto-merge (squash) July 8, 2026 10:04
@GuillaumeGomez GuillaumeGomez merged commit 2b9a25f into rust-lang:main Jul 8, 2026
14 checks passed
@GuillaumeGomez GuillaumeGomez deleted the fix-gui-test branch July 8, 2026 10:04
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants