Skip to content

Update embedded-hal dependency to 1.0.0-alpha.7#96

Closed
ahmedcharles wants to merge 1 commit into
rust-embedded:stagingfrom
ahmedcharles:embedded-hal-1.0-alpha
Closed

Update embedded-hal dependency to 1.0.0-alpha.7#96
ahmedcharles wants to merge 1 commit into
rust-embedded:stagingfrom
ahmedcharles:embedded-hal-1.0-alpha

Conversation

@ahmedcharles

Copy link
Copy Markdown

No description provided.

@ahmedcharles ahmedcharles requested a review from a team as a code owner February 23, 2022 05:44
@Disasm

Disasm commented Feb 23, 2022

Copy link
Copy Markdown
Member

Thank you for the PR! Could you explain how these alpha-updates should work? Do we need to release an alpha version of the riscv crate with this change? In any case, I don't think it's a good idea to merge it directly to master as this would create problems for regular releases.

@ahmedcharles

Copy link
Copy Markdown
Author

My current goal is to update various dependencies across all the crates locally so I can at least try to test them. The PRs are mostly to avoid duplicate effort.

Once I can flash something to my hifive revb, I'll make more concrete suggestions for how to release.

Thanks for commenting.

@ahmedcharles ahmedcharles force-pushed the embedded-hal-1.0-alpha branch from 7e7a130 to 72165e0 Compare February 24, 2022 20:44
@ahmedcharles ahmedcharles changed the base branch from master to staging February 24, 2022 20:50
@ahmedcharles

Copy link
Copy Markdown
Author

I updated the PR to update the version and switched to the staging branch. I think this would be the first crate that needs to be updated now that I have a test project compiling/working.

@Disasm

Disasm commented Mar 19, 2022

Copy link
Copy Markdown
Member

staging is a special branch used by bors for testing. I don't think it's a good idea to merge anything into it as it will be removed later.

@ahmedcharles

Copy link
Copy Markdown
Author

Ok, is there another branch I should merge it into for an alpha release?

@romancardenas

Copy link
Copy Markdown
Contributor

Closing, as this has been addressed in #147

romancardenas pushed a commit that referenced this pull request Nov 17, 2023
96: Add missing changelog entries r=almindor a=Disasm



Co-authored-by: Vadim Kaushan <admin@disasm.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants