Rust insta based tests - #210
Merged
jonathanpallant merged 8 commits intoAug 24, 2026
Merged
Conversation
jonathanpallant
requested changes
Jul 29, 2026
jonathanpallant
left a comment
jonathanpallant
left a comment
Contributor
There was a problem hiding this comment.
Thank you for these changes. I think the proposed solution is going to work well and I left you some thoughts.
Author
|
@jonathanpallant Please have a look when you've time. Hopefully I've address most of the comments in one way or the other. |
sriramster
force-pushed
the
rust_insta_based_tests
branch
from
August 5, 2026 05:03
f299118 to
988e18e
Compare
Author
|
@jonathanpallant would you please have a look at this? |
Contributor
|
I'm on vacation at the moment |
added 8 commits
August 24, 2026 15:14
This patch series introduces the rust insta crate based testing upgrade. The insta crate allows for snapshot comparison which is more powerful than the current bash script based testing framework. For documentation https://docs.rs/insta/latest/insta/ This patch introduces a new crate named qemu-tests. * The qemu-tests has a mod named common, which lists the bins available in each of the examples * Once bins are populated, we use rust's command execution from std, and call the `cargo run` with specific flags and --bin * Before validating the test suite needs to be bootstrapped for the insta to load the snapshot for comparsion please refer to justfile for notes on how to initialize the test suite. Signed-off-by: Sriram Raghunathan <sriram@hcoop.net>
… with insta crate Signed-off-by: Sriram Raghunathan <sriram@hcoop.net>
…rkflow to use updated test-qemu Signed-off-by: Sriram Raghunathan <sriram@hcoop.net>
Signed-off-by: Sriram Raghunathan <sriram@hcoop.net>
Signed-off-by: Sriram Raghunathan <sriram@hcoop.net>
Signed-off-by: Sriram Raghunathan <sriram@hcoop.net>
* Move back to older style target based invocation of tests. * Allow user to run target specific insta tests. * Adapt test framework accordingly. Signed-off-by: Sriram Raghunathan <sriram@hcoop.net>
tests. And control the execution with libtest_mimic addressing the review comments Signed-off-by: Sriram Raghunathan <sriram@hcoop.net>
jonathanpallant
force-pushed
the
rust_insta_based_tests
branch
from
August 24, 2026 14:14
988e18e to
d134bc4
Compare
jonathanpallant
approved these changes
Aug 24, 2026
Contributor
|
Tried it out on the CLI, and it works great. I like that I can run |
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch series introduces rust insta based testing framework. The insta framework documentation is available (https://docs.rs/insta/latest/insta/).
qemu-testsaarch32-testsThe PR address #138