Skip to content

chore: Resolve clippy collapsible_match failure in seq_len_from_cigar - #521

Merged
johanneskoester merged 3 commits into
masterfrom
copilot/fix-copilot-issue
Aug 15, 2026
Merged

chore: Resolve clippy collapsible_match failure in seq_len_from_cigar#521
johanneskoester merged 3 commits into
masterfrom
copilot/fix-copilot-issue

Conversation

Copilot AI commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

The CI lint job failed on clippy::collapsible_match in src/bam/ext.rs, blocking the workflow run linked in the issue. This change applies a minimal refactor to the flagged match arm while preserving sequence length semantics.

  • Lint-fix scope (minimal, behavior-preserving)

    • Replaced nested if include_hard_clip inside the Cigar::HardClip arm with a guarded match arm.
    • No logic changes outside seq_len_from_cigar.
  • Why this matters

    • Aligns the implementation with strict CI clippy settings (-D clippy::all) for this code path.
    • Keeps hard-clip inclusion behavior explicit at pattern-match level.
match entry {
    Cigar::HardClip(len) if include_hard_clip => {
        result += len;
    }
    // ...
}

Co-authored-by: johanneskoester <1858646+johanneskoester@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue with Copilot integration Resolve clippy collapsible_match failure in seq_len_from_cigar Aug 15, 2026
Copilot AI requested a review from johanneskoester August 15, 2026 10:29
@coveralls

coveralls commented Aug 15, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 31882266962

Coverage decreased (-0.005%) to 82.129%

Details

  • Coverage decreased (-0.005%) from the base build.
  • Patch coverage: 2 of 2 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3391
Covered Lines: 2785
Line Coverage: 82.13%
Coverage Strength: 27266.79 hits per line

💛 - Coveralls

@johanneskoester johanneskoester changed the title Resolve clippy collapsible_match failure in seq_len_from_cigar chore: Resolve clippy collapsible_match failure in seq_len_from_cigar Aug 15, 2026
@johanneskoester
johanneskoester marked this pull request as ready for review August 15, 2026 11:26
Co-authored-by: johanneskoester <1858646+johanneskoester@users.noreply.github.com>
Copilot AI requested a review from johanneskoester August 15, 2026 13:13
@johanneskoester
johanneskoester merged commit 9264a47 into master Aug 15, 2026
13 of 14 checks passed
@johanneskoester
johanneskoester deleted the copilot/fix-copilot-issue branch August 15, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants