Exporting reset_munmap_all_arenas to C and Python Bindings#1210
Merged
Conversation
jberthold
reviewed
Jul 2, 2025
Comment on lines
+434
to
+436
| void kllvm_reset_munmap_all_arenas(void) { | ||
| reset_munmap_all_arenas(); | ||
| } |
Collaborator
There was a problem hiding this comment.
We will also need this in the header file, right?
Collaborator
Author
There was a problem hiding this comment.
Yes, sorry!
Collaborator
Author
There was a problem hiding this comment.
I've just pushed this fix, thanks for spotting it!
jberthold
approved these changes
Jul 2, 2025
Robertorosmaninho
marked this pull request as ready for review
July 2, 2025 14:30
jberthold
added a commit
to runtimeverification/haskell-backend
that referenced
this pull request
Jul 2, 2025
Fixes a problem that surfaced in the `kontrol` upgrade (symptom: server crashes unexpectedly after some iterations). The LLVM backend was changed to not call `munmap` within `free_all_kore_mem` any more, which makes the `mmap` calls to initialise thread-local heap address space fail after a number of requests. This is a hot-fix which calls `reset_munmap_all_arenas`, a function not currently included in the LLVM backend C API. The function will be included in the API once runtimeverification/llvm-backend#1210 is merged, then the header file and the function name should be aligned with the API again. The backend is _not going to work with older LLVM backends_ because [the function that needs to be called is new as of June 7](runtimeverification/llvm-backend@facee2b).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP