Conversation
あったほうがいいっすね！ |
kerochelo
reviewed
May 6, 2021
| - ユーザーログアウト機能 | ||
| - 投稿編集・削除機能の制限 | ||
|
|
||
| 実装では課題と同様`sorcery`のgemを使用して、各機能ごとに以下の観点を満たすように実装してください。 |
There was a problem hiding this comment.
細かい文言ですが、「観点」より「ポイント」の方がいいかも
下の方も同じく「確認観点」→「確認ポイント」
判断はいとうさんに任せます:pray:
Contributor
Author
There was a problem hiding this comment.
「確認観点」はテストコードのitの文章に対応した名前なので、そっちも直さないといけなくなっちゃうんですよね、、
最初の「観点」だけ「ポイント」に変えておこうと思います！
Contributor
Author
There was a problem hiding this comment.
あ、でも「確認観点」が変わらないのであれば「ポイント」に変えなくてもいい気がしてきました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
完成形のGIFやHerokuでの完成版アプリの紹介は要らないですかね？
不足部分があれば指摘をお願いしますm(_ _)m