Add doctor suggestions for overlapping skill roots#177
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a suggestions field to the doctor check results in the skillshare command. It adds the addCheckWithSuggestions method to doctorResult, updates the doctorCheck struct to include a JSON-serializable Suggestions slice, and populates actionable suggestions when detecting shared target paths or cross-target discovery overlaps. Corresponding unit tests have also been updated to verify these suggestions. There are no review comments, and I have no feedback to provide.
Owner
|
@TIR44 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
suggestionsto doctor check JSON output.Context
Related to #135. The existing doctor checks already detect duplicate roots and cross-target discovery overlaps, but the warning output did not tell users what to do next. This keeps the change narrow: it does not add adopt/claim behavior, change sync semantics, or introduce new config models.
Validation
go test ./cmd/skillshare -run 'TestCheckSharedTargetPaths|TestCheckCrossTargetDiscovery|TestFinalizeDoctorJSON|TestFetchDoctorUpdateResult'make test-unitThe visible Vercel status points at a Vercel authorization URL; no Go test failure was observed locally.