Add dynamic line of sight#11807
Open
Maximuis94 wants to merge 13 commits intorunelite:masterfrom
Open
Conversation
…lection is not allowed" feedback properly and avoid any hacky workarounds, I realized the plugin's core architecture needed a refactor.
Here is what I've updated:
Removed Dynamic Class Loading: Overhauled the UI routing by removing the reflection-based panel instantiation and replacing it with explicit Guice bindings and a safe switch statement in DataLoggerPanel.
Removed Gson TypeToken Reflection: Removed the dynamic TypeToken reflection in FileIOService, replacing it with standard Java function parsing via the LogType enum.
Removed Method Invocation: Replaced the reflective invoke call with a direct client.getAccountHash() API call in the new AbstractLogger base class.
Let me know if everything looks good to go!
…nd avoid any hacky workarounds, I realized the plugin's core architecture needed a refactor.
I have made the following changes;
Removed Dynamic Class Loading: Overhauled the UI routing by removing the reflection-based panel instantiation and replacing it with explicit Guice bindings and a safe switch statement in DataLoggerPanel.
Removed Gson TypeToken Reflection: Removed the dynamic TypeToken reflection in FileIOService, replacing it with standard Java function parsing via the LogType enum.
Removed Method Invocation: Replaced the reflective invoke call with a direct client.getAccountHash() API call in the new AbstractLogger base class.
Let me know if everything looks good to go!
# Conflicts: # plugins/data-logger
Extends item prices in the bank interface to unowned placeholders, showing a tooltip with item name, GE and HA prices for them as well
Plugin that draws current the line of sight around the player. Line of sight can be based on the current active weapon, the manual spell cast range, as well as up to 5 custom, predefined ranges (next to the manual spell cast range and the active weapon range). All lines of sight with the exception of the manual spell cast range are affected by Myopia tier in fortis colosseum. Allows NPC lines of sight in Fight caves, Inferno and Fortis Colosseum to be drawn Allows the player line of sight to be drawn under the cursor, while the configured button is pressed.
|
New plugin |
|
Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin that draws current the line of sight around the player.
Line of sight can be based on the current active weapon, the manual spell cast range, as well as up to 5 custom, predefined ranges (next to the manual spell cast range and the active weapon range).
All lines of sight with the exception of the manual spell cast range are affected by Myopia tier in fortis colosseum.
Allows NPC lines of sight in Fight caves, Inferno and Fortis Colosseum to be drawn
Allows the player line of sight to be drawn under the cursor, while the configured button is pressed.