Skip to content

Add QuestPath#11771

Open
ripperosa wants to merge 4 commits intorunelite:masterfrom
ripperosa:master
Open

Add QuestPath#11771
ripperosa wants to merge 4 commits intorunelite:masterfrom
ripperosa:master

Conversation

@ripperosa
Copy link
Copy Markdown

QuestPath — quest prerequisite visualizer and planner for OSRS.

What it does

Pick any target quest, miniquest, or achievement diary. The plugin shows
the full prerequisite tree color-coded by completion, surfaces unmet skill
walls, and produces a topologically-ordered plan including training-method
suggestions weighted by Time / GP / AFK preference.

Data

257 quests / miniquests / diaries bundled as static JSON, derived from
Quest Helper's open-source helper classes (BSD-2-Clause). No Quest Helper
code is bundled — only structured requirement data parsed from their source.
The bundle is generated by a Python script at build time; the plugin makes
zero network requests at runtime.

Notes for reviewers

  • Reflection: the optional "Open in Quest Helper" hand-off uses reflection
    on Quest Helper's QuestManager (no public API exists). It is gated behind
    an opt-in config (enableQuestHelperHandoff, default false), so default
    users never trigger reflection. Happy to remove this entire path if it's
    a concern — it's isolated to one class (integration/QuestHelperBridge.java)
    and one button on the info card.
  • No HTTP, no file I/O outside the standard plugin config dir, no input
    injection, no PvM/PvP overlays.
  • LICENSE: BSD 2-Clause (matches Quest Helper's license, since we extract
    data from their source).

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 5, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 5, 2026

This plugin requires reviews from Plugin Hub reviewers. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

Copy link
Copy Markdown
Member

@tylerwgrass tylerwgrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Your plugin file is improperly formatted (spacing at the start of the lines)
  • Reflection is not allowed

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label May 5, 2026
@runelite-github-app runelite-github-app Bot removed waiting for author waiting for the pr author to make changes or respond to questions plugin added labels May 5, 2026
@ripperosa
Copy link
Copy Markdown
Author

  • Your plugin file is improperly formatted (spacing at the start of the lines)
  • Reflection is not allowed

Thanks for the review.

  • Removed the reflection-based Quest Helper bridge entirely. Deleted integration/QuestHelperBridge.java and its test, dropped the "Open in Quest Helper" button on the info card, and removed the enableQuestHelperHandoff config item. The plugin no longer uses reflection anywhere.
  • Recreated plugins/questpath from scratch with no leading whitespace.

Ready for re-review.

@ripperosa ripperosa requested a review from tylerwgrass May 5, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants