Removing Dependence on secrets.toml for environment variables#54
Open
nickknyc wants to merge 10 commits into
Open
Removing Dependence on secrets.toml for environment variables#54nickknyc wants to merge 10 commits into
nickknyc wants to merge 10 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #51 I have removed the use of
st.secretsand thus the need for using asecrets.tomlfile.Why
The
secrets.tomlis problematic when deploying to hosting other that streamlit/snowflake. In my case deploying to Azure Application Services resulted in an exposedsecrets.toml. This resulted in OpenAI automagically deleting the exposed key. Which in turn made my rags deployment fail at runtime.What
This PR has removed all of the uses of st.secrets and the secrets.toml file and instead sets up use of good old
os.getenv()