Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the plot.SupervisedSession method to rely on shared rtemis helpers for building the session timeline data and the kind→color mapping, keeping the visualization logic consistent with other rtemis-based renderers.
Changes:
- Replace the local session event parsing / DFS ordering logic with
rtemis::session_timeline(). - Replace the local kind color map logic with
rtemis::session_kind_colors(). - Bump the minimum required
rtemisversion to>= 1.2.8.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| r/R/plot.SupervisedSession.R | Switches timeline + colors to shared rtemis helpers and updates plotting documentation/comments accordingly. |
| r/DESCRIPTION | Updates the minimum rtemis dependency version to support the new helper usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| # One row per node, DFS order, ms offsets, unique indented labels, tooltip | ||
| # text, and a `failed` flag -- all computed by the shared rtemis helper. | ||
| tasks <- rtemis::session_timeline(x) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the rtemis dependency version in r/DESCRIPTION to >= 1.2.8. It also refactors plot.SupervisedSession.R by removing redundant local logic for rebuilding the execution tree, calculating timeline offsets, and mapping colors. Instead, it delegates these tasks to the shared helper functions rtemis::session_timeline() and rtemis::session_kind_colors(). There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
No description provided.