fix: only resolve bioc repositories when a project includes a bioc-sourced package#1340
Merged
Conversation
joshyam-k
commented
Jun 26, 2026
| bioc <- biocRepos(bundleDir) | ||
| if (any(bioc %in% repos)) { | ||
| biocPkgs <- NULL | ||
| # Only resolve Bioconductor repositories when the project actually contains a |
Contributor
Author
There was a problem hiding this comment.
sorry- I hate when github makes a diff look confusing like this. We're just wrapping the lines that were previously 62-64 and 66-67 with a new hasBiocPackage(...) gate.
karawoo
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1337
Instead of eagerly evaluating Bioconductor repositories, only do so when the project actually contains a Bioconductor-sourced package. This PR also creates a
isBiocPackagehelper that gets reused acrossR/bundlePackageRenv.RFollowing the reproduction steps in #1337:
Before
After