Change string concatenation to use pathlib - #118
Open
dennisbrookner wants to merge 1 commit into
Open
Conversation
pathlib objects cleverly override the `/` operator to mean "concatentate these file paths"; however, this means that pathlib objects *cannot* be concatenated by a `+` like you would with a string. This bug persisted because it lived in a rarely-used `else` block.
|
Hi @dennisbrookner, Rarely used indeed and yet it happened to me! Thanks for opening this branch. I had to modify my local version to get matchmaps to use my custom eff. Glad to see it is being addressed. Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pathlib objects cleverly override the
/operator to mean "concatentate these file paths"; however, this means that pathlib objects cannot be concatenated by a+like you would with a string.This bug persisted because it lived in a rarely-used
elseblock.