refactor: extract spawn_editor and upsert_repo_config helpers#27
Merged
Conversation
Owner
rrbe
commented
May 21, 2026
rrbe
commented
- feat: grove hook edit and grove config edit
- fix: don't persist sample config on no-change edit; surface TOML error on non-TTY
- refactor: extract spawn_editor and upsert_repo_config helpers
Move editor spawn logic into platform::{posix,windows} so cli.rs no
longer carries cfg-gated process plumbing, and centralize the
"insert-or-remove-if-empty" repo config write into store::upsert_repo_config
so cli and lib share one path.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rrbe
changed the title
Locks in the invariant that effectively-empty configs never sit in repo_configs as all-default placeholders. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.