Enable zeroization for X-Wing and X25519 secrets - #111
Merged
rozbb merged 1 commit intoJul 17, 2026
Conversation
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable the
zeroizefeatures ofx-wingandx25519-dalek.Without these features, the X-Wing decapsulation seed and the internal X25519
StaticSecret/SharedSecretvalues are not zeroized on drop, despite the X25519 wrapper comments stating that the underlying types are zeroize-on-drop.Both dependencies are updated explicitly because the classical X25519 feature can be enabled without the X-Wing/ML-KEM feature.
Closes #110