fix(ci): make pi codegen hermetic to unblock the check job (Closes #160) - #161
Merged
Merged
Conversation
The check job runs 'cd pi-fork && npm ci && npm run build', which regenerated pi's models.generated.ts from the live models.dev API at build time. Drift there emitted 'supportsReasoningEffort' on an openai-responses-typed literal, failing typecheck (TS2353) and blocking the downstream Typecheck and Test steps -- harness unit tests have not run in CI since 2026-08-20. Bump pi-fork to rossoctl/pi@2c28be5, which makes the ai package build hermetic (codegen split out of 'build') and widens OpenAIResponsesCompat so deliberate regeneration stays type-valid. See rossoctl/pi#1. Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
This was referenced Aug 25, 2026
pdettori
added a commit
that referenced
this pull request
Aug 25, 2026
setup-kind.sh built the harness image locally on every run, so a first-time quickstart hit the source build path — and any build breakage (e.g. #154's non-hermetic codegen, fixed separately in #161) blocked install with no workaround beyond --skip-build. Default to pulling the published image (ghcr.io/rossoctl/serverless-harness:latest, a public GHCR package) and loading it into kind, falling back transparently to a local build if the pull is unavailable (offline / image missing). This removes the local Docker build from the first-time path while staying non-regressing: - --build forces a local build (for testing local source changes) - --skip-build reuses a preloaded dev.local tag (unchanged) - --image / SH_IMAGE override the pulled image Image provisioning is extracted into ensure_harness_image() with a SH_SOURCE_ONLY guard so it can be unit-tested without a cluster; the new deploy/knative/tests/setup-kind-image.test.sh mocks docker/kind and asserts the pull / fallback-build / force-build / skip decision paths. The new-Revision build-ts stamp now fires whenever an image is (re)loaded (pull or build), not only on build. Docs (README-kind.md, serverless-harness-demo.md) updated for the new default. Refs #154 Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
pi-forksubmodule to a commit that makes pi's model codegenhermetic, unblocking the
checkjob.Closes #160.
Root cause
The
checkjob builds the submodule with:pi's
packages/aibuildscript regeneratedsrc/models.generated.tsfrom the live models.dev API on every build. models.dev is a moving
target: it emitted
supportsReasoningEfforton a model mapped to theopenai-responsesAPI, so the regenerated file no longer typecheckedagainst
OpenAIResponsesCompat:That failed the build step, so the downstream Typecheck and Test
steps never ran — harness unit tests have not executed in CI since
2026-08-20.
Fix
Bump
pi-fork→rossoctl/pi@2c28be5(rossoctl/pi#1), which:build, sonpm run buildruns onlytsgoagainst the committed generated files(no network fetch). A
check:models-driftscript is provided to catchstale generated files deliberately.
supportsReasoningEffortis added toOpenAIResponsesCompatso a deliberate regeneration stays valid.No workflow changes are needed; the existing
npm run buildis nowhermetic by virtue of the submodule fix.
Verification
tsgo -p tsconfig.build.jsononpackages/ai→ exit 0.checkjob through Typecheck andTest.
Assisted-By: Claude Code