Skip to content

Loaned message tests#241

Open
nightduck wants to merge 7 commits into
ros2:rollingfrom
nightduck:loaned-message-tests
Open

Loaned message tests#241
nightduck wants to merge 7 commits into
ros2:rollingfrom
nightduck:loaned-message-tests

Conversation

@nightduck
Copy link
Copy Markdown

@nightduck nightduck commented Mar 31, 2026

Description

This provides unit tests for the tracepoints added in rmw_cyclonedds PR#556 and rmw_fastrtps PR#871, confirming that the rmw_take tracepoint is called even when using zero-copy

Fixes #240

Is this user-facing behavior change?

No

Did you use Generative AI?

Yes, the initial draft was written entirely in Cursor's agentic tool. Review and revisions were done with a human (except the _CYCLO_DDS_SHM_XML string, which was AI generated)

Additional Information

Signed-off-by: Oren Bell <oren.bell@autonomous-teaming.ai>
Signed-off-by: Oren Bell <oren.bell@autonomous-teaming.ai>
Signed-off-by: Oren Bell <oren.bell@autonomous-teaming.ai>
Signed-off-by: Oren Bell <oren.bell@autonomous-teaming.ai>
Signed-off-by: Oren Bell <oren.bell@autonomous-teaming.ai>
@nightduck
Copy link
Copy Markdown
Author

I locally confirmed that this passes when built against the latest version of rmw_cyclonedds and rmw_fastrtps PR#871, and it fails when built against versions of rmw_cyclonedds and rmw_fastrtps from before these tracepoints were added:
rmw_cyclonedds: e7f44399fbadb474f0136370c232ed7eaf5be581
rmw_fastrtps: e5c8a84386fd9059f99ed6710ad4d7ac80f089b0

Signed-off-by: Oren Bell <oren.bell@autonomous-teaming.ai>
@nightduck nightduck force-pushed the loaned-message-tests branch from d1b70dd to e65f58f Compare March 31, 2026 14:36
@christophebedard christophebedard self-requested a review April 1, 2026 15:32
Comment thread test_tracetools/src/test_ping_loaned.cpp Outdated
Comment thread test_tracetools/src/test_ping_loaned.cpp Outdated
Signed-off-by: Oren Bell <oren.bell@autonomous-teaming.ai>
@christophebedard christophebedard self-assigned this Apr 16, 2026
@christophebedard
Copy link
Copy Markdown
Member

Pulls: #241
Gist: https://gist.githubusercontent.com/christophebedard/da8cd515281e71dc599c8b9a52e9add7/raw/dfc312de713dd967b3efd6ada33f92f258a077d7/ros2.repos
BUILD args: --packages-above-and-dependencies test_tracetools
TEST args: --packages-above test_tracetools
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19000

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard
Copy link
Copy Markdown
Member

@nightduck the new tests are failing on all Linux jobs. Can you take a look? Also, GitHub CI doesn't seem to like launching roudi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add loaned message pub-sub test to test_tracetools

2 participants