v1.6.15: PotPlayer in default ExcludedApps + migration framework - #5
Merged
Conversation
User report: dragging PotPlayer's (custom-chrome) title bar or double-clicking on the video area fires SnapActions's capture cascade. WM_COPY and the new v1.6.13 UIA layer both return empty (no text element), then the Ctrl+Insert fallback fires — PotPlayer interprets Ctrl+Insert as a non-copy shortcut, so the keystroke becomes a phantom input rather than a no-op. Fix: - AppSettings.cs: new ExcludedAppsDefaultsVersion property (default 0) tracking which generation of default-exclusions this file has absorbed. - SettingsManager.cs: new MigrateExcludedAppsDefaults run during Load, walks through ExcludedAppsDefaultsHistory and appends entries the file hasn't seen yet. Idempotent (dedup check), user-respecting (only ever adds, never removes). - ExcludedAppsDefaultsHistory[0] = PotPlayerMini64, PotPlayerMini (v1.6.15). Existing users upgrade to 1.6.15 → first time they trigger any save the ExcludedAppsDefaultsVersion bumps to 1 and PotPlayer entries persist. Users who want capture in PotPlayer can remove them via Settings → Excluded apps; the version is already 1 so they won't come back. The migration framework also gives us a clean knob for the next 'this app mis-fires Ctrl+Insert' report: append a new (version, apps) row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-reported fix: dragging PotPlayer's custom-chrome title bar or double-clicking on the video area was firing the Ctrl+Insert fallback, which PotPlayer interprets as a non-copy shortcut.
Fix
PotPlayerMini64andPotPlayerMiniadded to the default ExcludedApps list.ExcludedAppsDefaultsVersionfield +MigrateExcludedAppsDefaultsmechanism in SettingsManager: existing users' settings.json files pick up new defaults on Load without overwriting their own additions/removals. Idempotent.Users who want capture in PotPlayer can still remove these via Settings → Excluded apps; the version field ensures they won't get re-added on next launch.