fix: make consolidation timeouts configurable#970
Open
ggoldani wants to merge 1 commit into
Open
Conversation
|
@ggoldani is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
📝 WalkthroughWalkthroughTwo new timeout configuration utilities ( ChangesConfigurable Timeout Support
Possibly related issues
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/config-timeouts.test.ts`:
- Around line 93-98: The afterEach block currently only cleans up environment
variables but does not restore real timers, which means if a test fails before
individual timer restoration code executes, fake timers remain active and
contaminate subsequent tests. Add a call to jest.useRealTimers() at the end of
the afterEach block to ensure that real timers are always restored as part of
the shared cleanup, preventing timer state from leaking between tests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3d01c5f1-4bb0-4c76-b629-21a405c53577
📒 Files selected for processing (13)
.env.exampleREADME.mddeploy/coolify/entrypoint.shdeploy/fly/entrypoint.shdeploy/railway/entrypoint.shdeploy/render/entrypoint.sheval/scripts/sandbox.shiii-config.docker.yamliii-config.yamlsrc/config.tssrc/functions/consolidate.tssrc/index.tstest/config-timeouts.test.ts
Comment on lines
+93
to
+98
| afterEach(() => { | ||
| delete process.env["AGENTMEMORY_CONSOLIDATION_COMPRESS_TIMEOUT_MS"]; | ||
| delete process.env["AGENTMEMORY_LLM_TIMEOUT_MS"]; | ||
| delete process.env["OPENAI_TIMEOUT_MS"]; | ||
| delete process.env["AGENTMEMORY_INVOCATION_TIMEOUT_MS"]; | ||
| }); |
Contributor
There was a problem hiding this comment.
Restore real timers in shared cleanup to prevent cross-test leakage.
If a test fails before Line 152 or Line 190, fake timers remain active and can cascade flaky failures into later tests. Move timer restoration into afterEach so cleanup always runs.
Suggested fix
afterEach(() => {
+ vi.useRealTimers();
delete process.env["AGENTMEMORY_CONSOLIDATION_COMPRESS_TIMEOUT_MS"];
delete process.env["AGENTMEMORY_LLM_TIMEOUT_MS"];
delete process.env["OPENAI_TIMEOUT_MS"];
delete process.env["AGENTMEMORY_INVOCATION_TIMEOUT_MS"];
});🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@test/config-timeouts.test.ts` around lines 93 - 98, The afterEach block
currently only cleans up environment variables but does not restore real timers,
which means if a test fails before individual timer restoration code executes,
fake timers remain active and contaminate subsequent tests. Add a call to
jest.useRealTimers() at the end of the afterEach block to ensure that real
timers are always restored as part of the shared cleanup, preventing timer state
from leaking between tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Large semantic consolidations were failing even when the service/provider were healthy because timeouts were hardcoded in multiple layers:
mem::consolidateused a fixed 30scompress timeoutper conceptinvocationTimeoutMs: 180000default_timeout: 180000In real runs this caused failures like:
Invocation timeout after 180000ms: mem::consolidateFix
resolveTimeoutMs()/ boundedparsePositiveInt()in configmem::consolidatenow resolves timeout precedence as:AGENTMEMORY_CONSOLIDATION_COMPRESS_TIMEOUT_MSOPENAI_TIMEOUT_MSAGENTMEMORY_LLM_TIMEOUT_MS1200001000..300000msAGENTMEMORY_INVOCATION_TIMEOUT_MSwith clamp1000..600000ms600000msconsistently in:iii-config.yamliii-config.docker.yaml.env.exampleandREADME.mdValidation
npm run build✅npx vitest run test/config-timeouts.test.ts test/consolidate-project-scope.test.ts test/consolidation-default.test.ts✅dist/contains the new timeout logic and600000iii defaults ✅Invocation timeout after 180000mscompleted successfully in ~200.4s ({"consolidated":7,"totalObservations":30197}) ✅Notes
I intentionally kept this patch surgical: no provider API changes, no endpoint surface changes, just timeout configurability + consistency + regression coverage.
Summary by CodeRabbit
New Features
Documentation
Tests