fix: remove vulnerable glob runtime graph - #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
globdependency from 10.5.0 to 13.0.6 and pin transitive consumers to the supported runtime version.brace-expansion5.0.7, removing GHSA-3jxr-9vmj-r5cp from the production graph.npm run audit:prodtorelease:check, which is already the CI gate, and document it.Baseline evidence on
origin/main(0ec4945):npm ciwarned thatglob@10.5.0is deprecated, andnpm audit --omit=dev --jsonreported one high-severity production vulnerability inbrace-expansionwith two affected nodes.Commits
04d1f3ftest: lock file discovery behavior578f940fix: update runtime glob dependencya125e08ci: audit production dependencies in release checksa910a1edocs: document the production audit gateVerification
npm ci(no deprecated/unsupportedglobwarning)npm audit --omit=dev --json(0 production vulnerabilities)npm run release:check(71 tests passed; typecheck, lint, coverage, smoke, and package smoke passed)npm run validatenpm pack --dry-run(27 expected packed files)git diff --checkRisk Level
Notes:
globis a runtime major-version update. Its documented Node engine remains compatible with this package's Node 18 minimum, and discovery behavior is covered by targeted and full-suite tests.Rollback Plan
Human Decision Needed