Skip to content

Align CI and validation on release check #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rogerchappel merged 3 commits into from
Jun 16, 2026
Merged

Align CI and validation on release check #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be8967e
chore: include package smoke in validation
rogerchappel Jun 16, 2026
f65d938
ci: use package release check
rogerchappel Jun 16, 2026
d0f6078
docs: highlight release check for contributors
rogerchappel Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,4 @@ jobs:
node-version: 22
cache: npm
- run: npm ci
- run: npm run check
- run: npm run build
- run: npm test
- run: npm run smoke
- run: npm run package:smoke
- run: npm run release:check
8 changes: 7 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,13 @@ MIT © [Roger Chappel](https://github.com/rogerchappel)

## Development

Run the same checks locally before opening a PR:
Run the same release gate used by CI before opening a PR:

```bash
npm run release:check
```

The release gate covers:

- `npm run check` - tsc --noEmit
- `npm run lint` - eslint src --ext .ts
Expand Down
1 change: 1 addition & 0 deletions scripts/validate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ npm run check
npm run build
npm test
npm run smoke
npm run package:smoke

node dist/cli.js fixtures/fully-typed --format json --min-coverage 100 >/tmp/typegap-fully-typed.json
node -e "const fs=require('node:fs'); const r=JSON.parse(fs.readFileSync('/tmp/typegap-fully-typed.json','utf8')); if (r.coverage !== 100 || r.implicitCount !== 0) process.exit(1)"
Expand Down
Loading