Feature: Volume [In Progress] - #1
Open
varffs wants to merge 1 commit into
Open
Conversation
roc
approved these changes
Jun 16, 2023
roc
left a comment
roc
left a comment
Owner
There was a problem hiding this comment.
Thank you for this!
Left some nits, feel free to work on them or not. Otherwise can we mere mortals have a screenshot or two? Would be happy to have this in afterwards <3
| @@ -0,0 +1,10 @@ | |||
| // import { useEffect, useState } from "react"; | |||
| <input type="range" min={0} max={100} value={volume} onChange={(e) => (callback(e.target.value))} /> | ||
| </div> | ||
| ); | ||
| } No newline at end of file |
| // import { useEffect, useState } from "react"; | ||
|
|
||
| export default function DialKnob( {volume, callback}) { | ||
| // actually want this to be a knob not a slider |
| /> | ||
| ); | ||
| } | ||
| } No newline at end of file |
| const Channel = ({ title, now }: ChannelProps) => { | ||
| console.log(title, now, typeof title); | ||
| const Channel = ({ title, now, volume }: ChannelProps) => { | ||
| // console.log(title, now, typeof title); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So yh. I want a volume dial, but tbh just any volume would be good rn (because I can't adjust volume thru the audio interface without getting up and walking over and need that flexibility at desk).